Open
Conversation
cheeze-hyeon
requested changes
Apr 12, 2024
Contributor
cheeze-hyeon
left a comment
cheeze-hyeon
left a comment
There was a problem hiding this comment.
LGTM! 과제하느라 수고하셨습니다! 😸 그런데 지금 main <- yeonghun-week5-hw 로 PR 타겟이 설정되어 있는데 **yeonghun-week5** <- yeonghun-week5-hw 로 바꾸고 merge 해주셔야 해요!!
Comment on lines
+52
to
+59
| key={comment.id} | ||
| id={comment.id} | ||
| content={comment.content} | ||
| createdAt={comment.created_at} | ||
| postId={comment.post} | ||
| author={comment.author} | ||
| handleCommentDelete={handleCommentDelete} | ||
| handleCommentEdit={handleCommentEdit} |
Contributor
There was a problem hiding this comment.
Suggested change
| key={comment.id} | |
| id={comment.id} | |
| content={comment.content} | |
| createdAt={comment.created_at} | |
| postId={comment.post} | |
| author={comment.author} | |
| handleCommentDelete={handleCommentDelete} | |
| handleCommentEdit={handleCommentEdit} | |
| comment={comment} | |
| handleCommentDelete={handleCommentDelete} | |
| handleCommentEdit={handleCommentEdit} |
작성해준 방식으로 props를 넘겨줄 수도 있지만 comment 객체를 넘겨주는 건 어떨까요? 일일이 props를 적기에도 번거롭고 CommentElement에서 지금 모든 props를 활용하고 있지 않으니까 comment 자체를 넘겨주고 CommentElement에서 필요한 내용을 디스트럭처링 할당으로 활용하는 것도 좋을 것 같아요!
| @@ -1,21 +1,39 @@ | |||
| import { useState, useEffect } from "react"; | |||
Contributor
There was a problem hiding this comment.
과제 PR에는 과제 내용만 담기도록 해주세요! 세미나에서 했던 코드 작성 내용은 이름 브랜치에 푸쉬해두고 과제 브랜치로 바꿔서 과제 코드 작성하시면 됩니당~
|
LGTM 수고했어용 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💎 과제 구현 설명
🏁 PR 체크리스트
🖼️ Screenshot / Video
🙌 Issue